Add a missing include #6049
Merged
Add a missing include #6049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This missing include was not a problem in our standard build configuration, but was breaking other build configurations.
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
kripken
reviewed
Oct 24, 2023
|
|
||
| #include "ir/find_all.h" | ||
| #include "ir/local-graph.h" | ||
| #include "lattice.h" |
Member
There was a problem hiding this comment.
I see we use FinitePowersetLattice below. Shouldn't we include src/analysis/lattices/powerset.h?
kripken
approved these changes
Oct 24, 2023
ashleynh
approved these changes
Oct 24, 2023
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
These missing includes were not a problem in our standard build configuration, but were breaking other build configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing include was not a problem in our standard build configuration, but
was breaking other build configurations.