[analysis][NFC] Refactor lattice unit tests #6065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2023
Member
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
tlively
force-pushed
the
valtype-lattice
branch
from
3c29d25 to
2d99383
Compare
tlively
force-pushed
the
refactor-lattice-gtest
branch
from
1226fba to
518957f
Compare
tlively
force-pushed
the
valtype-lattice
branch
from
2d99383 to
33139e2
Compare
tlively
force-pushed
the
refactor-lattice-gtest
branch
from
518957f to
e8e0ab4
Compare
kripken
approved these changes
Oct 31, 2023
tlively
force-pushed
the
refactor-lattice-gtest
branch
from
e8e0ab4 to
f65d8a0
Compare
Many of the lattice tests were essentially copy-pasted from one lattice to the next because they all tested isomorphic subsets of the various lattices, specifically in the shape of a diamond. Refactor the code so that all lattices that have tests of this shape use the same utility test functions.
tlively
force-pushed
the
refactor-lattice-gtest
branch
from
f65d8a0 to
3e6b7dd
Compare
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Many of the lattice tests were essentially copy-pasted from one lattice to the next because they all tested isomorphic subsets of the various lattices, specifically in the shape of a diamond. Refactor the code so that all lattices that have tests of this shape use the same utility test functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the lattice tests were essentially copy-pasted from one lattice to the
next because they all tested isomorphic subsets of the various lattices,
specifically in the shape of a diamond. Refactor the code so that all lattices
that have tests of this shape use the same utility test functions.