Skip to content

[Outlining] Add variations of call_indirect tests #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashleynh merged 5 commits into from
Dec 7, 2023
Merged

[Outlining] Add variations of call_indirect tests #6152

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e55c5e9
[𝘀𝗽𝗿] changes to main this commit is based on
ashleynh Dec 7, 2023
96e96bb
[𝘀𝗽𝗿] initial version
ashleynh Dec 7, 2023
353b4b9
curious
ashleynh Dec 7, 2023
c262e5b
feedback
ashleynh Dec 7, 2023
55ebcd5
singular
ashleynh Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 120 additions & 15 deletions test/lit/passes/outlining.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,9 +691,28 @@
)

;; Test outlining works with call_indirect
;; 0 results, 2 params, 3 operands
(module
(table funcref)
(func
;; CHECK: (type $0 (func))

;; CHECK: (type $1 (func (param i32 i32)))

;; CHECK: (table $0 0 funcref)

;; CHECK: (func $outline$ (type $0)
;; CHECK-NEXT: (call_indirect $0 (type $1)
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: (i32.const 2)
;; CHECK-NEXT: )
;; CHECK-NEXT: )

;; CHECK: (func $a (type $0)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: )
(func $a
(call_indirect
(param i32 i32)
(i32.const 0)
Expand All @@ -708,24 +727,110 @@
)
)
)
;; CHECK: (type $0 (func))

;; CHECK: (type $1 (func (param i32 i32)))
;; Test outlining works with call_indirect
;; 0 results, 2 params, 3 operands
(module
(table funcref)
;; CHECK: (type $0 (func))

;; CHECK: (type $1 (func (param i32 i32)))

;; CHECK: (table $0 0 funcref)

;; CHECK: (func $outline$ (type $0)
;; CHECK-NEXT: (call_indirect $0 (type $1)
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: (i32.const 2)
;; CHECK-NEXT: )
;; CHECK-NEXT: )

;; CHECK: (func $a (type $0)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: )
(func $a
(call_indirect
(param i32 i32)
(i32.const 0)
(i32.const 1)
(i32.const 2)
)
(call_indirect
(param i32 i32)
(i32.const 0)
(i32.const 1)
(i32.const 2)
)
)
)

;; Test outlining works with call_indirect
;; 0 results, 0 params, 1 operand
(module
(table funcref)
;; CHECK: (type $0 (func))

;; CHECK: (table $0 0 funcref)

;; CHECK: (func $outline$ (type $0)
;; CHECK-NEXT: (call_indirect $0 (type $0)
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: )

;; CHECK: (func $a (type $0)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: )
(func $a
(call_indirect
(i32.const 0)
)
(call_indirect
(i32.const 0)
)
)
)

;; Test outlining works with call_indirect
;; 1 result, 0 params, 1 operand
(module
(table funcref)
;; CHECK: (type $0 (func))

;; CHECK: (table $0 0 funcref)
;; CHECK: (type $1 (func (result i32)))

;; CHECK: (func $outline$ (type $0)
;; CHECK-NEXT: (call_indirect $0 (type $1)
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: (i32.const 2)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK: (table $0 0 funcref)

;; CHECK: (func $0 (type $0)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: )
;; CHECK: (func $outline$ (type $0)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (call_indirect $0 (type $1)
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: )

;; CHECK: (func $a (type $0)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: (call $outline$)
;; CHECK-NEXT: )
(func $a
(drop
(call_indirect
(result i32)
(i32.const 0)
)
)
(drop
(call_indirect
(result i32)
(i32.const 0)
)
)
)
)

;; Outline a loop
;; TODO: Ideally, a loop (like any control flow) repeated within a program can
Expand Down