Skip to content

SimplifyGlobals: Propagate constant globals into nested gets in other globals #6285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 2 commits into from
Feb 8, 2024
Merged

SimplifyGlobals: Propagate constant globals into nested gets in other globals #6285

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1849ea3
fix
kripken Feb 7, 2024
8a69037
fix
kripken Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix
  • Loading branch information
@kripken
kripken committed Feb 7, 2024
commit 8a69037444cd10bc7701bf30507ebc014026d850
27 changes: 27 additions & 0 deletions test/lit/passes/simplify-globals-nested.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
;; NOTE: This test was ported using port_passes_tests_to_lit.py and could be cleaned up.

;; RUN: foreach %s %t wasm-opt --simplify-globals -all -S -o - | filecheck %s

;; Test that we propagate globals into nested children of other globals.

(module
;; CHECK: (type $struct (struct (field i32) (field i32)))
(type $struct (struct i32 i32))

;; CHECK: (global $a i32 (i32.const 42))
(global $a i32 (i32.const 42))

;; CHECK: (global $b i32 (i32.const 1337))
(global $b i32 (i32.const 1337))

;; CHECK: (global $struct (ref $struct) (struct.new $struct
;; CHECK-NEXT: (i32.const 42)
;; CHECK-NEXT: (i32.const 1337)
;; CHECK-NEXT: ))
(global $struct (ref $struct) (struct.new $struct
(global.get $a)
(global.get $b)
))
Comment on lines +22 to +25
Copy link
Member

@tlively tlively Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this is already tested elsewhere, but it might be nice to see that a global.get where the value cannot be propagated (because it is a GC data allocation, for instance) does not interfere with propagation of the other global.gets.

Copy link
Member Author

@kripken kripken Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "does not interfere"? Like if it is in the middle between them?

Copy link
Member

@tlively tlively Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in the middle, necessarily, but yeah, if this struct had another field initialized with another global.get, but that one couldn't be propagated.

)