Skip to content

Fuzzer: Add SIMD support to DeNaN #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 15 commits into from
Feb 21, 2024
Merged

Fuzzer: Add SIMD support to DeNaN #6318

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
aefdf03
start
kripken Feb 15, 2024
43bb800
sad
kripken Feb 15, 2024
2a75520
work
kripken Feb 15, 2024
7c7ff81
fix
kripken Feb 15, 2024
44e6c86
fix
kripken Feb 15, 2024
96469aa
fix
kripken Feb 15, 2024
0cea4f4
work
kripken Feb 15, 2024
d195c00
work
kripken Feb 15, 2024
42e81f2
finish
kripken Feb 15, 2024
d970d6a
work
kripken Feb 15, 2024
d4bfec9
format
kripken Feb 15, 2024
66c2c50
comment
kripken Feb 15, 2024
eaf35dc
Merge remote-tracking branch 'origin/main' into fuzz.simd.nan
kripken Feb 20, 2024
c08fa5d
feedback
kripken Feb 20, 2024
cf07915
format
kripken Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@kripken
kripken committed Feb 15, 2024
commit 96469aa00dc71e69c9bf84496df48d338da9e181
4 changes: 2 additions & 2 deletions test/lit/passes/denan-simd.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@
(drop
(v128.const i32x4 0x00000001 0x00000002 0x00000003 0x00000004)
Copy link
Member

@tlively tlively Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to write the tests using f32x4 and f64x2 shapes rather than i32x4 so we can better see what values are being passed. You can use the --new-wat-parser and its extensive support for the standard nan formats if you want.

Copy link
Member Author

@kripken kripken Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking it is nice to see the actual bits because of how they are used in the pass (the explanation about the f32 and f64 bits overlapping etc.)?

Copy link
Member Author

@kripken kripken Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more specific, in this test code:

    ;; This is an f64 NaN and also an f32. It will become 0's.
    (drop
      (v128.const i32x4 0xffffffff 0x00000002 0x00000003 0x00000004)
    )
    ;; This is an f32 NaN and not an f64. It will also become 0's.
    (drop
      (v128.const i32x4 0x00000001 0xffffffff 0x00000003 0x00000004)
    )

It is nice to see the bits, because that allows the comments to clarify how the same bits can be both f32 and f64 nans, or not.

Copy link
Member

@tlively tlively Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more convinced by this if readers were likely to know off the top of their heads what bit patterns correspond to NaNs. I know I don't :)

Copy link
Member Author

@kripken kripken Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I don't know that either, but I mentioned it in the pass (8 vs 11 top non-sign bits).

)
;; This is an f64 NaN and also an f32.
;; This is an f64 NaN and also an f32. It will become 0's.
(drop
(v128.const i32x4 0xffffffff 0x00000002 0x00000003 0x00000004)
)
;; This is an f32 NaN and not an f64.
;; This is an f32 NaN and not an f64. It will also become 0's.
(drop
(v128.const i32x4 0x00000001 0xffffffff 0x00000003 0x00000004)
)
Expand Down