Skip to content

Strings: Disable precomputing for now #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 3 commits into from
Mar 20, 2024
Merged

Strings: Disable precomputing for now #6412

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b40f49
Disable string precomputing
kripken Mar 20, 2024
e9ef3a9
tests
kripken Mar 20, 2024
159ca62
format
kripken Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format
  • Loading branch information
@kripken
kripken committed Mar 20, 2024
commit 159ca6208697ed40d760597d08a5f91284249105
24 changes: 6 additions & 18 deletions src/passes/Precompute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,27 +198,15 @@ class PrecomputingExpressionRunner

// Disable string operations pending investigation of the correctness of our
// UTF implementation. FIXME
Flow visitStringNew(StringNew* curr) {
return Flow(NONCONSTANT_FLOW);
}
Flow visitStringConst(StringConst* curr) {
return Flow(NONCONSTANT_FLOW);
}
Flow visitStringNew(StringNew* curr) { return Flow(NONCONSTANT_FLOW); }
Flow visitStringConst(StringConst* curr) { return Flow(NONCONSTANT_FLOW); }
Flow visitStringMeasure(StringMeasure* curr) {
return Flow(NONCONSTANT_FLOW);
}
Flow visitStringConcat(StringConcat* curr) {
return Flow(NONCONSTANT_FLOW);
}
Flow visitStringEncode(StringEncode* curr) {
return Flow(NONCONSTANT_FLOW);
}
Flow visitStringEq(StringEq* curr) {
return Flow(NONCONSTANT_FLOW);
}
Flow visitStringAs(StringAs* curr) {
return Flow(NONCONSTANT_FLOW);
}
Flow visitStringConcat(StringConcat* curr) { return Flow(NONCONSTANT_FLOW); }
Flow visitStringEncode(StringEncode* curr) { return Flow(NONCONSTANT_FLOW); }
Flow visitStringEq(StringEq* curr) { return Flow(NONCONSTANT_FLOW); }
Flow visitStringAs(StringAs* curr) { return Flow(NONCONSTANT_FLOW); }
Flow visitStringWTF8Advance(StringWTF8Advance* curr) {
return Flow(NONCONSTANT_FLOW);
}
Expand Down