Skip to content

Asyncify: Fix nondeterminism in verbose logging #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 3 commits into from
Apr 9, 2024
Merged

Asyncify: Fix nondeterminism in verbose logging #6479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b0499f
note+fix
kripken Apr 9, 2024
762d3fb
update test
kripken Apr 9, 2024
d3ba312
typo
kripken Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test
  • Loading branch information
@kripken
kripken committed Apr 9, 2024
commit 762d3fb53eb76ef6b1dc87973f043f19553d7a5e
2 changes: 1 addition & 1 deletion src/passes/Asyncify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ class ModuleAnalyzer {
!info.inRemoveList;
},
[](Info& info) { info.canChangeState = true; },
[verbose](const Info& info, Function* reason) {
[&](const Info& info, Function* reason) {
if (verbose) {
std::stringstream str;
str << "[asyncify] " << info.name
Expand Down
42 changes: 19 additions & 23 deletions test/lit/passes/asyncify_verbose.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,36 @@
;; RUN: foreach %s %t wasm-opt --asyncify --pass-arg=asyncify-verbose -q | filecheck %s

;; The import is reported as changing the state, as all imports can.
;; The import is reported as changing the state, as all imports can. The
;; function that calls it, consequently, is also reported as such, and so on
;; further up the chain.
;;
;; CHECK: [asyncify] import is an import that can change the state

;; The function that calls the import can change the state too.
;;
;; CHECK: [asyncify] calls-import can change the state due to import

;; Likewise, further up the call chain as well.
;;
;; CHECK: [asyncify] calls-calls-import can change the state due to calls-import
;; CHECK: [asyncify] calls-calls-import-b can change the state due to calls-import
;; CHECK: [asyncify] calls-calls-calls-import can change the state due to calls-calls-import
;; CHECK: [asyncify] calls-calls-calls-import can change the state due to calls-calls-import-b
;; CHECK: [asyncify] a-import is an import that can change the state
;; CHECK: [asyncify] calls-a-import can change the state due to a-import
;; CHECK: [asyncify] calls-calls-a-import can change the state due to calls-a-import
;; CHECK: [asyncify] calls-calls-a-import-b can change the state due to calls-a-import
;; CHECK: [asyncify] calls-calls-calls-a-import can change the state due to calls-calls-a-import
;; CHECK: [asyncify] calls-calls-calls-a-import can change the state due to calls-calls-a-import-b

(module
(import "env" "import" (func $import))
(import "env" "import" (func $a-import))

(memory 1 2)

(func $calls-import
(call $import)
(func $calls-a-import
(call $a-import)
)

(func $calls-calls-import
(call $calls-import)
(func $calls-calls-a-import
(call $calls-a-import)
)

(func $calls-calls-import-b
(call $calls-import)
(func $calls-calls-a-import-b
(call $calls-a-import)
)

(func $calls-calls-calls-import
(call $calls-calls-import)
(call $calls-calls-import-b)
(func $calls-calls-calls-a-import
(call $calls-calls-a-import)
(call $calls-calls-a-import-b)
)

(func $nothing
Expand Down