Skip to content

SignaturePruning: Properly handle public types #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 11 commits into from
May 29, 2024
Merged

SignaturePruning: Properly handle public types #6630

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
54d8e73
fix
kripken May 28, 2024
6487897
hmm
kripken May 28, 2024
9da9900
fix
kripken May 28, 2024
cba4a85
close
kripken May 28, 2024
1c72e1e
work
kripken May 28, 2024
fceb73a
fix
kripken May 28, 2024
5f82586
format
kripken May 28, 2024
a4904ed
comment
kripken May 28, 2024
e3fb49c
wat
kripken May 28, 2024
56900e6
fastr
kripken May 29, 2024
2213028
Update src/passes/SignaturePruning.cpp
kripken May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment
  • Loading branch information
@kripken
kripken committed May 28, 2024
commit a4904ed47fc40bcc896a1dbd70a9ddafbda181a5
4 changes: 3 additions & 1 deletion test/lit/passes/signature-pruning.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,9 @@
;; $exported is exported. The entire rec group becomes exported as well, which
;; causes $unused-param's type to be public, which means we cannot normally
;; modify it. However, in closed world we allow such changes, and we can remove
;; the unused param there.
;; the unused param there. What happens is that we keep the original public rec
;; group as-is, and add a new rec group for private types, put the pruned type
;; there, and use that pruned type on $unused-param.
(module
(rec
;; CHECK: (rec
Expand Down