Skip to content

Fix validation of unused LEB128 bits #6680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 2 commits into from
Jun 19, 2024
Merged

Fix validation of unused LEB128 bits #6680

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a67bf
Fix validation of unused LEB128 bits
tlively Jun 18, 2024
5c8bd00
127
tlively Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
127
  • Loading branch information
@tlively
tlively committed Jun 19, 2024
commit 5c8bd008403bd5b735c5ccc76a723112b142ae98
2 changes: 1 addition & 1 deletion src/wasm-binary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ template<typename T, typename MiniT> struct LEB {
: ((mask_type(1) << (sizeof(T) * 8 - shift)) - 1u);
T significant_payload = payload_mask & payload;
value |= significant_payload << shift;
T unused_bits_mask = ~payload_mask & 0x7F;
T unused_bits_mask = ~payload_mask & 127;
T unused_bits = payload & unused_bits_mask;
if (std::is_signed_v<T> && value < 0) {
if (unused_bits != unused_bits_mask) {
Expand Down