Skip to content

[WasmGC] Heap2Local: Optimize RefCast failures #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 28 commits into from
Jul 11, 2024
Merged

[WasmGC] Heap2Local: Optimize RefCast failures #6727

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a4e1778
almost
kripken Jun 21, 2024
38f2297
work
kripken Jun 24, 2024
3009f94
work
kripken Jun 24, 2024
10a8b9d
work
kripken Jun 24, 2024
43e5381
Undo.opt
kripken Jun 24, 2024
d36281b
re-do
kripken Jun 24, 2024
1c11a1e
Revert "re-do"
kripken Jun 24, 2024
19823a6
format
kripken Jun 24, 2024
078b813
almost
kripken Jun 24, 2024
090af2d
work
kripken Jun 24, 2024
49d7545
Merge remote-tracking branch 'origin/main' into heap2local.ref.eq
kripken Jun 25, 2024
60050be
fix
kripken Jun 25, 2024
dea6db5
add two more tests
kripken Jun 25, 2024
9029ba2
improve test
kripken Jun 25, 2024
f305e4f
more
kripken Jun 25, 2024
8d26f56
test
kripken Jun 25, 2024
cffde15
todo
kripken Jun 25, 2024
66f8b13
work
kripken Jun 25, 2024
72c9b60
test
kripken Jun 25, 2024
fd71b16
formt
kripken Jun 25, 2024
4193d58
test
kripken Jun 25, 2024
1eb9848
fix
kripken Jun 25, 2024
56d5e98
merge
kripken Jun 26, 2024
584b750
yolo
kripken Jul 3, 2024
3488e5d
fix
kripken Jul 3, 2024
f5a998c
Merge remote-tracking branch 'myself/heap2local.ref.is' into heap2loc…
kripken Jul 3, 2024
d6d4d12
Merge remote-tracking branch 'origin/main' into heap2local.castfailz
kripken Jul 11, 2024
6df1b8b
clarify in a comment
kripken Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add two more tests
  • Loading branch information
@kripken
kripken committed Jun 25, 2024
commit dea6db54ddda7f1d8dc9d2360caacd829baf6397
80 changes: 80 additions & 0 deletions test/lit/passes/heap2local.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@

;; CHECK: (type $12 (func (param eqref) (result i32)))

;; CHECK: (type $13 (func (param eqref eqref) (result i32)))

;; CHECK: (func $simple (type $1)
;; CHECK-NEXT: (local $0 i32)
;; CHECK-NEXT: (local $1 f64)
Expand Down Expand Up @@ -2273,6 +2275,84 @@
)
)
)

;; CHECK: (func $ref-eq-unrelated (type $13) (param $x eqref) (param $y eqref) (result i32)
;; CHECK-NEXT: (ref.eq
;; CHECK-NEXT: (local.get $x)
;; CHECK-NEXT: (local.get $y)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $ref-eq-unrelated (param $x eqref) (param $y eqref) (result i32)
;; We know nothing about either arm, and do nothing.
(ref.eq
(local.get $x)
(local.get $y)
)
)

;; CHECK: (func $ref-eq-two (type $4) (result i32)
;; CHECK-NEXT: (local $0 i32)
;; CHECK-NEXT: (local $1 f64)
;; CHECK-NEXT: (local $2 i32)
;; CHECK-NEXT: (local $3 f64)
;; CHECK-NEXT: (local $4 i32)
;; CHECK-NEXT: (local $5 f64)
;; CHECK-NEXT: (local $6 i32)
;; CHECK-NEXT: (local $7 f64)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (block (result i32)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (ref.eq
;; CHECK-NEXT: (block (result nullref)
;; CHECK-NEXT: (local.set $2
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: (local.set $3
;; CHECK-NEXT: (f64.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: (local.set $0
;; CHECK-NEXT: (local.get $2)
;; CHECK-NEXT: )
;; CHECK-NEXT: (local.set $1
;; CHECK-NEXT: (local.get $3)
;; CHECK-NEXT: )
;; CHECK-NEXT: (ref.null none)
;; CHECK-NEXT: )
;; CHECK-NEXT: (block (result nullref)
;; CHECK-NEXT: (local.set $6
;; CHECK-NEXT: (i32.const 1)
;; CHECK-NEXT: )
;; CHECK-NEXT: (local.set $7
;; CHECK-NEXT: (f64.const 2.2)
;; CHECK-NEXT: )
;; CHECK-NEXT: (local.set $4
;; CHECK-NEXT: (local.get $6)
;; CHECK-NEXT: )
;; CHECK-NEXT: (local.set $5
;; CHECK-NEXT: (local.get $7)
;; CHECK-NEXT: )
;; CHECK-NEXT: (ref.null none)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
(func $ref-eq-two (result i32)
;; Two separate allocations. We can optimize them away, and the result is 0.
(ref.eq
(struct.new $struct.A
(i32.const 0)
(f64.const 0)
)
(struct.new $struct.A
(i32.const 1)
(f64.const 2.2)
)
)
)
)

(module
Expand Down