Skip to content

Monomorphize dropped functions #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 36 commits into from
Jul 12, 2024
Merged

Monomorphize dropped functions #6734

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
fd6ab9d
drop
kripken Jul 11, 2024
170a6f0
yolo
kripken Jul 11, 2024
206339e
yolo
kripken Jul 11, 2024
79b695e
yolo
kripken Jul 11, 2024
6595096
yolo
kripken Jul 11, 2024
35a2483
test+fix
kripken Jul 11, 2024
ba38860
test+fix
kripken Jul 11, 2024
ed76396
test
kripken Jul 11, 2024
d64ef3a
test
kripken Jul 11, 2024
16da290
test
kripken Jul 11, 2024
81661bc
work
kripken Jul 11, 2024
75c264b
Merge remote-tracking branch 'origin/main' into monodrop
kripken Jul 11, 2024
44b20cc
work
kripken Jul 11, 2024
6047297
comment
kripken Jul 11, 2024
d460fba
fix
kripken Jul 11, 2024
923387f
fix
kripken Jul 11, 2024
9c67aa8
handle return_call*
kripken Jul 11, 2024
b04fdc3
format
kripken Jul 11, 2024
cc1356f
add missing returns
kripken Jul 11, 2024
5ea3675
format
kripken Jul 11, 2024
4d6f9b4
rework return_calls
kripken Jul 12, 2024
635e91d
builds
kripken Jul 12, 2024
48e1aaa
format
kripken Jul 12, 2024
7ed19e8
whoops
kripken Jul 12, 2024
099872a
work
kripken Jul 12, 2024
6a5419f
tests
kripken Jul 12, 2024
561714f
test.work
kripken Jul 12, 2024
403fdac
test.work
kripken Jul 12, 2024
ce13223
fix.test
kripken Jul 12, 2024
c6a653e
fix
kripken Jul 12, 2024
021b396
work
kripken Jul 12, 2024
4efae3d
test
kripken Jul 12, 2024
b8b5fa7
Avoid a libc++ compiler error
kripken Jul 12, 2024
916e73f
format
kripken Jul 12, 2024
6a0cbac
todo
kripken Jul 12, 2024
339c96c
modularize test
kripken Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
work
  • Loading branch information
@kripken
kripken committed Jul 12, 2024
commit 099872a9ff31fc814a772da558bc7fe663e27a0c
96 changes: 34 additions & 62 deletions test/lit/passes/monomorphize-drop.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
;; ALWAYS: (type $iii (func (param i32 i32) (result i32)))

;; ALWAYS: (type $i (func (result i32)))
;; CAREFUL: (type $0 (func))

;; CAREFUL: (type $iii (func (param i32 i32) (result i32)))

;; CAREFUL: (type $i (func (result i32)))
Expand All @@ -32,6 +30,8 @@
;; ALWAYS: (type $5 (func (param i32 i32)))

;; ALWAYS: (import "a" "b" (func $import (type $iii) (param i32 i32) (result i32)))
;; CAREFUL: (type $2 (func))

;; CAREFUL: (type $3 (func (param i32)))

;; CAREFUL: (type $4 (func (param i32) (result i32)))
Expand Down Expand Up @@ -59,6 +59,8 @@
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; CAREFUL: (elem declare func $import)

;; CAREFUL: (func $work (type $iii) (param $0 i32) (param $1 i32) (result i32)
;; CAREFUL-NEXT: (i32.mul
;; CAREFUL-NEXT: (i32.add
Expand Down Expand Up @@ -187,7 +189,7 @@
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; CAREFUL: (func $call-import (type $0)
;; CAREFUL: (func $call-import (type $2)
;; CAREFUL-NEXT: (drop
;; CAREFUL-NEXT: (call $import
;; CAREFUL-NEXT: (i32.const 3)
Expand Down Expand Up @@ -246,7 +248,7 @@
;; ALWAYS: (func $call-import-work (type $0)
;; ALWAYS-NEXT: (call $import-work_14)
;; ALWAYS-NEXT: )
;; CAREFUL: (func $call-import-work (type $0)
;; CAREFUL: (func $call-import-work (type $2)
;; CAREFUL-NEXT: (drop
;; CAREFUL-NEXT: (call $import-work
;; CAREFUL-NEXT: (i32.const 3)
Expand Down Expand Up @@ -306,13 +308,15 @@
;; ALWAYS-NEXT: (i32.const 4)
;; ALWAYS-NEXT: )
;; CAREFUL: (func $many-returns (type $i) (result i32)
;; CAREFUL-NEXT: (if (result i32)
;; CAREFUL-NEXT: (if
;; CAREFUL-NEXT: (call $import
;; CAREFUL-NEXT: (i32.const 1)
;; CAREFUL-NEXT: (i32.const 2)
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: (then
;; CAREFUL-NEXT: (i32.const 3)
;; CAREFUL-NEXT: (return
;; CAREFUL-NEXT: (i32.const 3)
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: (else
;; CAREFUL-NEXT: (return_call $import
Expand All @@ -321,6 +325,25 @@
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: (if
;; CAREFUL-NEXT: (call $import
;; CAREFUL-NEXT: (i32.const 6)
;; CAREFUL-NEXT: (i32.const 7)
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: (then
;; CAREFUL-NEXT: (return_call_indirect $table (type $i)
;; CAREFUL-NEXT: (i32.const 8)
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: (else
;; CAREFUL-NEXT: (return_call_ref $iii
;; CAREFUL-NEXT: (i32.const 1)
;; CAREFUL-NEXT: (i32.const 2)
;; CAREFUL-NEXT: (ref.func $import)
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: )
;; CAREFUL-NEXT: (i32.const 4)
;; CAREFUL-NEXT: )
(func $many-returns (result i32)
;; This function returns in every possible way, which we need to handle in
Expand Down Expand Up @@ -365,9 +388,11 @@
)

;; ALWAYS: (func $call-many-returns (type $0)
;; ALWAYS-NEXT: (call $many-returns_15)
;; ALWAYS-NEXT: (drop
;; ALWAYS-NEXT: (call $many-returns)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; CAREFUL: (func $call-many-returns (type $0)
;; CAREFUL: (func $call-many-returns (type $2)
;; CAREFUL-NEXT: (drop
;; CAREFUL-NEXT: (call $many-returns)
;; CAREFUL-NEXT: )
Expand Down Expand Up @@ -503,60 +528,7 @@
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )

;; ALWAYS: (func $many-returns_15 (type $0)
;; ALWAYS-NEXT: (drop
;; ALWAYS-NEXT: (block (result i32)
;; ALWAYS-NEXT: (if
;; ALWAYS-NEXT: (call $import
;; ALWAYS-NEXT: (i32.const 1)
;; ALWAYS-NEXT: (i32.const 2)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (then
;; ALWAYS-NEXT: (drop
;; ALWAYS-NEXT: (i32.const 3)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (return)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (else
;; ALWAYS-NEXT: (drop
;; ALWAYS-NEXT: (call $import
;; ALWAYS-NEXT: (i32.const 4)
;; ALWAYS-NEXT: (i32.const 5)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (return)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (if
;; ALWAYS-NEXT: (call $import
;; ALWAYS-NEXT: (i32.const 6)
;; ALWAYS-NEXT: (i32.const 7)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (then
;; ALWAYS-NEXT: (drop
;; ALWAYS-NEXT: (call_indirect $table (type $i)
;; ALWAYS-NEXT: (i32.const 8)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (return)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (else
;; ALWAYS-NEXT: (drop
;; ALWAYS-NEXT: (call_ref $iii
;; ALWAYS-NEXT: (i32.const 1)
;; ALWAYS-NEXT: (i32.const 2)
;; ALWAYS-NEXT: (ref.func $import)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (return)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: (i32.const 4)
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )
;; ALWAYS-NEXT: )

;; CAREFUL: (func $work_10 (type $0)
;; CAREFUL: (func $work_10 (type $2)
;; CAREFUL-NEXT: (nop)
;; CAREFUL-NEXT: )

Expand Down