Skip to content

binaryen.js: Avoid catching exit/rejection which confuses Node error reporting #6764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 2 commits into from
Jul 17, 2024
Merged

binaryen.js: Avoid catching exit/rejection which confuses Node error reporting #6764

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e2483
binaryen.js: Avoid catching exit/rejection which confuses Node error …
kripken Jul 17, 2024
905bc1c
feedback: Remove rejection flag
kripken Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
binaryen.js: Avoid catching exit/rejection which confuses Node error … 
…reporting
  • Loading branch information
@kripken
kripken committed Jul 17, 2024
commit 58e24831cd35d3320c9830abdd21ef551858deea
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,10 @@ if(EMSCRIPTEN)
target_link_libraries(binaryen_wasm optimized "-Wno-error=closure")
target_link_libraries(binaryen_wasm optimized "-flto")
target_link_libraries(binaryen_wasm debug "--profiling")
# Avoid catching exit/rejection as that can confuse error reporting in Node,
# see https://github.com/emscripten-core/emscripten/issues/17228
target_link_libraries(binaryen_wasm "-sNODEJS_CATCH_EXIT=0")
Copy link
Member

@sbc100 sbc100 Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in the process of trying to disable this by default, but this change lgtm either way.

target_link_libraries(binaryen_wasm "-sNODEJS_CATCH_REJECTION=0")
Copy link
Member

@sbc100 sbc100 Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODEJS_CATCH_REJECTION is no longer needed here since it already defaults to 0 when targetting node > 15 (which is the default).

Copy link
Member Author

@kripken kripken Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I verified it still works that way. Pushed.

install(TARGETS binaryen_wasm DESTINATION ${CMAKE_INSTALL_BINDIR})

# binaryen.js JavaScript variant
Expand Down Expand Up @@ -550,6 +554,10 @@ if(EMSCRIPTEN)
target_link_libraries(binaryen_js optimized "-flto")
target_link_libraries(binaryen_js debug "--profiling")
target_link_libraries(binaryen_js debug "-sASSERTIONS")
# Avoid catching exit/rejection as that can confuse error reporting in Node,
# see https://github.com/emscripten-core/emscripten/issues/17228
target_link_libraries(binaryen_js "-sNODEJS_CATCH_EXIT=0")
target_link_libraries(binaryen_js "-sNODEJS_CATCH_REJECTION=0")
install(TARGETS binaryen_js DESTINATION ${CMAKE_INSTALL_BINDIR})
endif()

Expand Down