Skip to content

Generalize Literal::externalize/internalize for strings and shareability #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 8 commits into from
Jul 29, 2024
Merged

Generalize Literal::externalize/internalize for strings and shareability #6784

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02f1265
fix
kripken Jul 24, 2024
4abb99b
finish
kripken Jul 24, 2024
dad3d48
Merge remote-tracking branch 'origin/main' into extern.string
kripken Jul 25, 2024
914acfd
try
kripken Jul 25, 2024
a5f5b7d
fix
kripken Jul 25, 2024
1e937c3
Update src/wasm/literal.cpp
kripken Jul 29, 2024
3a299bd
fix destructor
kripken Jul 29, 2024
13f6db3
fix
kripken Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix destructor
  • Loading branch information
@kripken
kripken committed Jul 29, 2024
commit 3a299bd2307753f592ca49084d7492903dd163b2
2 changes: 1 addition & 1 deletion src/wasm/literal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ Literal::~Literal() {
if (type.isBasic()) {
return;
}
if (isNull() || isData() || type.getHeapType() == HeapType::ext) {
if (isNull() || isData() || type.getHeapType().isMaybeShared(HeapType::ext)) {
gcData.~shared_ptr();
}
}
Expand Down