Skip to content

Add a customizable title to Metrics reporting #6792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 4 commits into from
Jul 30, 2024
Merged

Add a customizable title to Metrics reporting #6792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e10622
work
kripken Jul 30, 2024
aedf8ea
more
kripken Jul 30, 2024
c4459a2
doc
kripken Jul 30, 2024
17d0842
changelog
kripken Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc
  • Loading branch information
@kripken
kripken committed Jul 30, 2024
commit c4459a2c80c9d1314f541da045fc8b0cf47b4359
2 changes: 1 addition & 1 deletion src/passes/pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ void PassRegistry::registerPasses() {
registerPass(
"merge-locals", "merges locals when beneficial", createMergeLocalsPass);
registerPass("metrics",
"reports metrics (--metrics[=TITLE])",
"reports metrics (with an optional title, --metrics[=TITLE])",
createMetricsPass);
registerPass("minify-imports",
"minifies import names (only those, and not export names), and "
Expand Down
4 changes: 3 additions & 1 deletion test/lit/help/wasm-metadce.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,9 @@
;; CHECK-NEXT: --merge-similar-functions merges similar functions when
;; CHECK-NEXT: benefical
;; CHECK-NEXT:
;; CHECK-NEXT: --metrics reports metrics
;; CHECK-NEXT: --metrics reports metrics (with an
;; CHECK-NEXT: optional title,
;; CHECK-NEXT: --metrics[=TITLE])
;; CHECK-NEXT:
;; CHECK-NEXT: --minify-imports minifies import names (only
;; CHECK-NEXT: those, and not export names),
Expand Down
4 changes: 3 additions & 1 deletion test/lit/help/wasm-opt.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,9 @@
;; CHECK-NEXT: --merge-similar-functions merges similar functions when
;; CHECK-NEXT: benefical
;; CHECK-NEXT:
;; CHECK-NEXT: --metrics reports metrics
;; CHECK-NEXT: --metrics reports metrics (with an
;; CHECK-NEXT: optional title,
;; CHECK-NEXT: --metrics[=TITLE])
;; CHECK-NEXT:
;; CHECK-NEXT: --minify-imports minifies import names (only
;; CHECK-NEXT: those, and not export names),
Expand Down
4 changes: 3 additions & 1 deletion test/lit/help/wasm2js.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@
;; CHECK-NEXT: --merge-similar-functions merges similar functions when
;; CHECK-NEXT: benefical
;; CHECK-NEXT:
;; CHECK-NEXT: --metrics reports metrics
;; CHECK-NEXT: --metrics reports metrics (with an
;; CHECK-NEXT: optional title,
;; CHECK-NEXT: --metrics[=TITLE])
;; CHECK-NEXT:
;; CHECK-NEXT: --minify-imports minifies import names (only
;; CHECK-NEXT: those, and not export names),
Expand Down