Local decls rewrite#41
Merged
Merged
Conversation
Member
|
Cool, thanks. You can run the tests locally with EDIT: Whoops, this was totally wrong. |
Author
|
With the rebase of dumps, those tests pass. There are still a couple failures on d8, but those are good ole compiler bugs that i'm puzzled weren't hit before...oh...i know...they are DCHECKs and you run in release mode :-) |
binji
force-pushed
the
local_decls_rewrite
branch
from
5984db5 to
9db7119
Compare
wenyongh
pushed a commit
to wenyongh/wabt
that referenced
this pull request
Jan 30, 2024
These can appear in relocations related to debug info. Also, print the name of the offending symbol if it refers to an invalid segment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL. The dump tests don't pass, since they assert on bytes. I wasn't sure how to update them. Depends on V8 CL: https://codereview.chromium.org/1763433002/