This repository was archived by the owner on Jan 3, 2019. It is now read-only.
URLSearchParams.prototype.sort #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2017 19:11
As requested in order to fix #22. The method is patched for native constructors that haven't implemented it yet. However, even constructoring via records or sequences might be broken. In those cases there is still no patch or the whole constructor needs to be substituted. TODO: decide if it's the case to feature detect upfront and globally replace the class if not standard also probably return strings like native (quite some work, not sure if worth it)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in order to fix #22.
The method is patched for native constructors that haven't implemented it yet.
However, even constructoring via records or sequences might be broken.
In those cases there is still no patch or the whole constructor needs to be substituted.
TODO