Skip to content

Fix checks for some control entites #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillCodeForCats merged 5 commits into from
May 3, 2026
Merged

Fix checks for some control entites #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6817df
Missing check for advanced power control sensors
WillCodeForCats May 3, 2026
20c49e5
Missing check for global power control sensors
WillCodeForCats May 3, 2026
955e3bc
Refactor checks for advanced and global power control number entites
WillCodeForCats May 3, 2026
c00c2b3
Format with black
WillCodeForCats May 3, 2026
558a1e7
Merge branch 'main' into code-quality
WillCodeForCats May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions custom_components/solaredge_modbus_multi/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,19 @@ async def async_setup_entry(

entities = []

""" Dynamic Power Control """
if hub.option_detect_extras:
for inverter in hub.inverters:
for inverter in hub.inverters:
"""Dynamic Power Control"""
if hub.option_detect_extras and inverter.global_power_control:
entities.append(
SolarEdgeActivePowerLimitSet(inverter, config_entry, coordinator)
)
entities.append(SolarEdgeCosPhiSet(inverter, config_entry, coordinator))

""" Power Control Block """
if hub.option_detect_extras and inverter.advanced_power_control:
entities.append(SolarEdgePowerReduce(inverter, config_entry, coordinator))
entities.append(SolarEdgeCurrentLimit(inverter, config_entry, coordinator))

""" Power Control Options: Storage Control """
if hub.option_storage_control is True:
for inverter in hub.inverters:
Expand All @@ -63,12 +68,6 @@ async def async_setup_entry(
SolarEdgeExternalProductionMax(inverter, config_entry, coordinator)
)

""" Power Control Block """
if hub.option_detect_extras and inverter.advanced_power_control:
for inverter in hub.inverters:
entities.append(SolarEdgePowerReduce(inverter, config_entry, coordinator))
entities.append(SolarEdgeCurrentLimit(inverter, config_entry, coordinator))

if entities:
async_add_entities(entities)

Expand Down
5 changes: 2 additions & 3 deletions custom_components/solaredge_modbus_multi/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,14 @@ async def async_setup_entry(
entities.append(DCPower(inverter, config_entry, coordinator))
entities.append(HeatSinkTemperature(inverter, config_entry, coordinator))

if hub.option_detect_extras:
if hub.option_detect_extras and inverter.global_power_control:
entities.append(SolarEdgeRRCR(inverter, config_entry, coordinator))
entities.append(
SolarEdgeActivePowerLimit(inverter, config_entry, coordinator)
)
entities.append(SolarEdgeCosPhi(inverter, config_entry, coordinator))

""" Power Control Block """
if hub.option_detect_extras:
if hub.option_detect_extras and inverter.advanced_power_control:
entities.append(
SolarEdgeCommitControlSettings(inverter, config_entry, coordinator)
)
Expand Down
Loading