PHP 8.1: fix deprecation notices in Requests_Transport_cURL
#500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Requests_Transport_cURL:;setup_handle()` and `Requests_Transport_cURL::format_get()` methods, both call the PHP native `http_build_query()` function. The second parameter of which is the _optional_ `$numeric_prefix` parameter which expects a `string`. A parameter being optional, however, does not automatically make it nullable. As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice. In this case, both these function calls yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice. Changing the `null` to an empty string fixes this without BC-break. This change is already covered by tests as 15 of the existing tests failed on these function calls when running the tests on PHP 8.1. Refs: * https://www.php.net/manual/en/function.http-build-query.php * https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
This was referenced Jun 21, 2021
schlessera
approved these changes
Jul 30, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Requests_Transport_cURL::setup_handle()andRequests_Transport_cURL::format_get()methods, both call the PHP nativehttp_build_query()function.The second parameter of which is the optional
$numeric_prefixparameter which expects astring.A parameter being optional, however, does not automatically make it nullable.
As of PHP 8.1, passing
nullto a non-nullable PHP native function will generate a deprecation notice.In this case, both these function calls yielded a
http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecatednotice.Changing the
nullto an empty string fixes this without BC-break.This change is already covered by tests as 15 of the existing tests failed on these function calls when running the tests on PHP 8.1.
Refs: