Skip to content

Requests.php: always set body text from response #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Requests.php: always set body text from response #933

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b443fa
Requests.php: always set body
granthony Jun 17, 2025
da20ed7
Requests.php: always set body text, if present
granthony Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Requests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,10 +738,8 @@

$headers = substr($return->raw, 0, $pos);
// Headers will always be separated from the body by two new lines - `\n\r\n\r`.
$body = substr($return->raw, $pos + 4);

Check warning on line 741 in src/Requests.php

View workflow job for this annotation

GitHub Actions / PHPCS 

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space
if (!empty($body)) {
$return->body = $body;
}
$return->body = $body;
}

// Pretend CRLF = LF for compatibility (RFC 2616, section 19.3)
Expand Down
Loading