Updates the google-fonts-with-previews.json to contain woff2 and new previews #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
changed the title
Member
|
These changes look good to me and I see the same changes if I generate them locally 👍
I agree, we can discuss this in a follow-up. |
mikachan
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
google-fonts-with-previews.jsonfile to include the link to the woff2 files( added by Add Google Fonts capability option #3 ).ℹ️ As a follow-up, maybe we need to add a way to avoid committing all the preview files for a given release.
Why?
To have an updated version of the file featuring the latest additions.