Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Update for latest gutenberg compatibility #23

Merged
aduth merged 13 commits into from
Aug 13, 2018
Merged

Update for latest gutenberg compatibility #23

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
68f28d7
Update for gutenberg 2.9 compatibility
ajitbohra May 31, 2018
a52df7c
Add text domain & setLocale
ajitbohra Jun 4, 2018
5c0d85d
Fix coding standards
ajitbohra Jul 9, 2018
feb53a7
Config eslint & fix code
ajitbohra Aug 1, 2018
f4b1aba
Merge branch 'master' of github.com:ajitbohra/gutenberg-examples
ajitbohra Aug 1, 2018
151bd61
Load locale data & refactor assets loading
ajitbohra Aug 3, 2018
2518aae
Clean .gitignore & .eslintignore
ajitbohra Aug 3, 2018
112440d
Use var for es5 examples instead of const
ajitbohra Aug 3, 2018
87b8161
Move gutenberg check to top
ajitbohra Aug 3, 2018
455d715
Handle undefined alignment
ajitbohra Aug 3, 2018
91c1699
Merge branch 'master' into master
ajitbohra Aug 13, 2018
0f82a2d
Fix className on save
ajitbohra Aug 13, 2018
eb2d489
Merge branch 'master' of github.com:ajitbohra/gutenberg-examples
ajitbohra Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions 01-basic-esnext/block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { __ } = wp.i18n;
const { __, setLocaleData } = wp.i18n;
const { registerBlockType } = wp.blocks;

const blockStyle = {
Expand All @@ -7,8 +7,10 @@ const blockStyle = {
padding: '20px',
};

setLocaleData( { '': {} }, 'gutenberg-examples' );
Copy link
Member

@iandunn iandunn Jul 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to include the localized strings and current locale via gutenberg_get_jed_locale_data() ?

For example: https://github.com/swissspidy/gutenberg-i18n-block/blob/c2c59155f1dbbc957fa1531e42a4e4a490555253/gutenberg-i18n-block.php#L78

Related #27
cc @swissspidy

If so, then I think this approach might be a more readable, because it separates the data from the code:

// foo.php
wp_add_inline_script(
	'syntaxhighlighter-blocks',
	sprintf( '
		var syntaxHighlighterData = {
			localeData: %s
		};',
		json_encode( gutenberg_get_jed_locale_data( 'syntaxhighlighter' ) ),
	),
	'before'
);
// foo.js
setLocaleData( syntaxHighlighterData.localeData, 'syntaxhighlighter' );

Copy link
Member Author

@ajitbohra ajitbohra Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right also this changes will help in understanding how to add localization to blocks.
will update all examples to properly implement localization.

Thank you


registerBlockType( 'gutenberg-examples/example-01-basic-esnext', {
title: __( 'Example: Basic (esnext)' ),
title: __( 'Example: Basic (esnext)', 'gutenberg-examples' ),
icon: 'universal-access-alt',
category: 'layout',
edit() {
Expand Down
Loading