Editor: straight quotes don't filter to curly quotes on publish as expected

[lancewillett]

Issue Overview

An amazing feature of the WordPress editing experience is you can enter "dumb" quotes, aka straight quotes or primes — and when the post is filtered for view with wp_texturize they automagically turn into curly quotes for proper typography.

Steps to Reproduce (for bugs)

1. Make a new post with Gutenberg, I tested with v 1.6.1 and WP trunk (latest Safari on macOS)
2. Publish and view the resulting post in the front-end

Expected Behavior

I expected ' to turn into ’ and " to turn into ”.

Current Behavior

Instead, the quotes stayed the same (straight primes).

Possible Solution

I'm not sure, but it could have to do with Gutenberg post content not being filtered properly through the built-in WP texturize functions.

Screenshots

Gutenberg editor view

After publishing on the front-end

Related Issues and/or PRs

Noticed this when debugging punctuation weirdness on https://ma.tt/2017/11/new-backpack-aer-fit-pack/

[lancewillett]

Looking at the raw post HTML it looks like Gutenberg converts simple quotes into entities:

<!-- wp:paragraph -->\n<p>It&#x27;s been a great day so far (I typed a prime there.)</p>\n<!-- /wp:paragraph -->\n\n<!-- wp:paragraph -->\n<p>This�ll be great (I typed a curly quote).</p>\n<!-- /wp:paragraph -->

So it's possible texturize is ignoring ' since it already looks converted?

[aduth]

This appears to be another issue of React's default string sanitization for block serialization working against us, since the WordPress texturize step is not expecting these to be represented as entities.

A couple ideas:

• Expand the entities which wptexturize replaces to include these values
• Reimplement our own save serialization which skips the sanitization

Related issues with serialization:

• Pasting inline shortcodes produces separate block #3806 (comment)
• Try: Framework-agnostic block interoperability (Vanilla, Vue) #2463
• Alternative to dangerouslySetInnerHTML in block save #421
• Quote: Fix new quote, transform from list block #2349 (comment)
• Editable: state as a cleaned up tree #3048

[lancewillett]

Re-testing after fixes with fd08045

Looks good! Texturize in the front-end output works as expected. Chrome latest on macOS, Gutenberg 2.6.0 and WP 4.9.5.

Editor:

Front-end output: