-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Labels
[Feature] MediaAnything that impacts the experience of managing mediaAnything that impacts the experience of managing media[Package] Format library/packages/format-library/packages/format-library[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended
Description
The "Inline Image" format opens two media modals. It calls the modal open method directly in the MediaUpload.render prop. It is a hack to emulate modal opening on a click, but React will call the class component methods like render twice in development. See: #61943.
Affected e2e tests
editor/various/adding-inline-tokens.spec.js- should insert inline image.
Steps to reproduce
- Checkout branch from Try: Re-enable React StrictMode #61943.
- Enable
SCRIPT_DEBUGfor nonwp-envsetups. - Create a post.
- Add a paragraph block.
- Try adding an inline image.
Metadata
Metadata
Assignees
Labels
[Feature] MediaAnything that impacts the experience of managing mediaAnything that impacts the experience of managing media[Package] Format library/packages/format-library/packages/format-library[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Type] BugAn existing feature does not function as intendedAn existing feature does not function as intended