Regression: `Block Toolbar` should not render when interacting with `Dimension Controls`

[yogeshbhutkar]

Description

When adding spacing (e.g., margin or padding) to a block, a blue highlight appears to indicate the amount of spacing applied. However, this highlight overlaps the Block Toolbar, making the toolbar options harder to see. The Block Toolbar should be displayed above the spacing highlight to ensure its options remain fully visible when adjusting block spacing.

If this issue seems like a duplicate of some other issue or is an intended behavior, please feel free to close this one.

Step-by-step reproduction instructions

1. Navigate to the post edit page.
2. Create any Block.
3. Try changing the Block's margin.
4. Confirm the spacing highlight overlaps with the Toolbar.

Screenshots, screen recording, code snippet

Environment info

• WordPress Version: 6.8-alpha-59361
• Gutenberg Version: Trunk (74986ed)
• OS: macOS Sequoia

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[Mamaduka]

It is worth checking the original PRs for this feature; this could be the intentional or known effect that should be ignored.

Labeling this as a low-priority bug since users still get the proper visual feedback.

[Mayank-Tripathi32]

I personally believe this might have been intentional, as the margin highlight appears specifically when adjusting the margin. It has a higher priority, so it is designed to be visible above the toolbar. I will look up the previous issues to see if it has been discussed before.

[stokesman]

Intentional or not it feels unpolished to me. I'm not sure it’d be much improved by having the block toolbar in front. I wonder if it might be better to hide the block toolbar while the visualizer is visible.

[Mayank-Tripathi32]

Intentional or not it feels unpolished to me. I'm not sure it’d be much improved by having the block toolbar in front. I wonder if it might be better to hide the block toolbar while the visualizer is visible.

Yea, that might be better actually. We can make it so that while highlight is showing the toolbar is disabled.

[yogeshbhutkar]

it might be better to hide the block toolbar while the visualizer is visible.

It makes sense, we won't use the toolbar when setting up the spacing. We should probably wait for design feedback on this one.

[stokesman]

It makes sense, we won't use the toolbar when setting up the spacing. We should probably wait for design feedback on this one.

Actually it appears this was already done before in #45131. I haven’t investigated what regressed it. I doubt that was intentional but I haven’t investigated.

[yogeshbhutkar]

Thanks for the research, @stokesman.

This looks like a regression, likely introduced in #56914 while refactoring focus conditions after #56335.

After reviewing these PRs and related changes, it seems unintentional to me. The expected behavior was well-defined and previously resolved as part of #44700.

Moreover, the isBlockInterfaceHidden selector is now unused across the entire codebase after the refactor.

[yogeshbhutkar]

I've created #69795 to address this and would greatly appreciate a review.