Skip to content

Docs: Fix grammar.md manifest entry; (chore) update data docs #10014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcsf merged 1 commit into from
Sep 18, 2018
Merged

Docs: Fix grammar.md manifest entry; (chore) update data docs #10014

mcsf merged 1 commit into from
Sep 18, 2018

Conversation

@mcsf
Copy link
Contributor

@mcsf mcsf commented Sep 18, 2018

Description

Follow-up on #9837 (comment). I'd mistakenly updated docs/manifest.json, which is auto-generated from other sources, including docs/root-manifest.json.

Testing

Run npm run docs:build, make sure that docs/manifest.json is kept intact (that the entry for grammar.md isn't removed).

@mcsf mcsf added the [Type] Developer Documentation Documentation for developers label Sep 18, 2018
@mcsf mcsf mentioned this pull request Sep 18, 2018
Merged
aduth
aduth approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@mcsf mcsf added this to the 4.0 milestone Sep 18, 2018
@mcsf mcsf merged commit c9d3669 into master Sep 18, 2018
@mcsf mcsf deleted the fix/docs-grammar-root-manifest branch September 18, 2018 20:39
@yassine4999 yassine4999 mentioned this pull request Jun 20, 2023
Open
This was referenced Jun 20, 2023
Open
Open
This was referenced Jul 6, 2023
Open
Open
Open
@yassine4999 yassine4999 mentioned this pull request Jul 8, 2023
Open
This was referenced Nov 27, 2023
Open
Open
This was referenced Nov 28, 2023
Open
Open
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Dec 2, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Dec 13, 2023
Open
@yassine4999 yassine4999 mentioned this pull request Dec 13, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Dec 15, 2023
Open
@yassine4999 yassine4999 mentioned this pull request Dec 18, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Dec 26, 2023
Open
This was referenced Mar 22, 2024
Open
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Apr 7, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Apr 30, 2024
Open
@yassine4999 yassine4999 mentioned this pull request May 13, 2024
Open
This was referenced May 14, 2024
Open
Open
@yassine4999 yassine4999 mentioned this pull request May 14, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request May 15, 2024
Open
@yassine4999 yassine4999 mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth aduth approved these changes

Assignees

No one assigned

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcsf @aduth