Skip to content

fix: Show "Publish Immediately" #10183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tofumatt wants to merge 1 commit into from
Closed

fix: Show "Publish Immediately" #10183

tofumatt wants to merge 1 commit into from

Conversation

@tofumatt
Copy link
Member

@tofumatt tofumatt commented Sep 26, 2018

Depends on #7621.

Description

Shows "Publish: Immediately" if the publishing date for the post is now or before now.

How has this been tested?

Tested locally and included E2E tests.

Screenshots

Will come after #7621 is merged...

@tofumatt
fix: Show "Publish Immediately"
8509802 
* Close #7195
* Close #8395
* Close #9030
* Close #9967
* Fix #10182
@tofumatt tofumatt added [Status] In Progress Tracking issues with work in progress [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Sep 26, 2018
@tofumatt tofumatt self-assigned this Sep 26, 2018
@pento
Copy link
Member

pento commented Sep 26, 2018

I don't think this is the correct behaviour: the author can actively choose a publication date in the past, in which case it should show that.

classic editor publish box of a draft, with the publication date set to the past

@tofumatt
Copy link
Member Author

tofumatt commented Sep 26, 2018

Why should we show the exact date in the past though? The effect is that it will be published immediately. The published date will still be set to be in the past, but it will go live immediately.

I guess if we do that already we want to, but it's an odd UX to me 🤷‍♂️

(At any rate the E2E tests here should at least be added because this seems to be a regression; we used to show "immediately" but no longer do and we didn't have anything to catch that.)

@earnjam
Copy link
Contributor

earnjam commented Sep 26, 2018

After discussing this one pretty extensively on the core REST API side, we came to the agreement that the best solution would be the method in #9967. It fixes the publish date label problem in while maintaining consistency with the UX of the classic editor.

@kadamwhite
Copy link
Contributor

kadamwhite commented Sep 26, 2018

+1 on @earnjam's note; and from a UX perspective, if you intentionally back-date a post that feels like important information to communicate. Otherwise we'd end up having people expect it to be published "Immediately", but then find it's several pages back in their archives if the date is a ways back.

@kadamwhite
Copy link
Contributor

kadamwhite commented Sep 27, 2018

Closing this in favor of #9967

@kadamwhite kadamwhite closed this Sep 27, 2018
@kadamwhite kadamwhite deleted the fix/publish-immediately-10182 branch September 27, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tofumatt tofumatt

Labels

[Status] Blocked Used to indicate that a current effort isn't able to move forward [Status] In Progress Tracking issues with work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tofumatt @pento @earnjam @kadamwhite