Gracefully handle multiple installed copies of the Gutenberg plugin #1020
Conversation
|
Should we avoid naming zip files this way to eliminate the underlying cause? |
|
Possibly, though at least a bit of this damage is already done because we released This PR may also be overkill for something that will only affect a couple of users, and maybe we just decide that we can address it satisfactorily by moving future releases to the plugin directory. |
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Yeah, this is another one I could go either way on. The impact does seem very very minimal at most, so added logic may be wasted for such an edge case.
|
|
||
| require_once dirname( __FILE__ ) . '/lib/check-duplicate-plugins.php'; | ||
| if ( defined( 'GUTENBERG_MULTIPLE_COPIES' ) && GUTENBERG_MULTIPLE_COPIES ) { | ||
| return; |
There was a problem hiding this comment.
Interested to find some weird repercussions of return used outside functions like this:
http://php.net/manual/en/function.return.php#112515
I suppose it's not a problem here because the functions aren't truly part of the same file. Perhaps fragile all the same though, if ever we were to add any functions to this file, since we'll encounter the same problem meant to be addressed by these changes (duplicate function declaration).
Better solution might be to wrap the require_once with the condition instead.
There was a problem hiding this comment.
Our plugin entry point should do as little as possible, only constants and requires and perhaps some very simple checks like in this PR.
|
I think I'll close this one out. It's unlikely to be a big problem after we release to the plugin directory. |
While finishing up #985 I discovered that installing multiple copies of the Gutenberg plugin on a site will cause the following error:
This is likely to be a problem for some users because we did an early release in Slack with the filename
gutenberg-2017-05-24.zip. WordPress will install this plugin zip into a folder namedgutenberg-2017-05-24. Then, when a user installs an updated version of the Gutenberg plugin, whether from Slack, the plugin directory once it is released there, or somewhere else, they will see the above error.We should detect this condition and handle it gracefully (have the duplicate version(s) of the plugin just bail out). This is accomplished in this branch: