Skip to content

Try: Larger drag handles #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisvanpatten merged 5 commits into from
Oct 4, 2018
Merged

Try: Larger drag handles #10331

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8acfdc
Try larger drag handles on the spacer block
chrisvanpatten Oct 4, 2018
b02d52b
Move resize styles to mixins, document use of !important, apply to im…
chrisvanpatten Oct 4, 2018
9091b5c
Use BEM-ish/more descriptive names for the mixins
chrisvanpatten Oct 4, 2018
235e8dc
Un-set inline styles on drag handles to avoid !important
chrisvanpatten Oct 4, 2018
a7060ae
Add some full stops, full stop.
chrisvanpatten Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use BEM-ish/more descriptive names for the mixins
  • Loading branch information
@chrisvanpatten
chrisvanpatten committed Oct 4, 2018
commit 9091b5cdeb8206e9822bda3d5351396e2f884b36
4 changes: 2 additions & 2 deletions edit-post/assets/stylesheets/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@
* Styles for resize handles
*/

@mixin resize-handler-container() {
@mixin resize-handler__container() {
display: none;

// The unfortunate use of `!important` in the CSS below is because the
Expand All @@ -347,7 +347,7 @@
padding: $grid-size-small;
}

@mixin resize-handler() {
@mixin resize-handler__visible-handle() {
display: block;
content: "";
width: $resize-handler-size;
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/image/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
.block-library-image__resize-handler-right,
.block-library-image__resize-handler-bottom,
.block-library-image__resize-handler-left {
@include resize-handler-container();
@include resize-handler__container();

.wp-block-image.is-focused & {
display: block;
Expand All @@ -37,7 +37,7 @@
.block-library-image__resize-handler-right::before,
.block-library-image__resize-handler-bottom::before,
.block-library-image__resize-handler-left::before {
@include resize-handler();
@include resize-handler__visible-handle();
}

/*!rtl:begin:ignore*/
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/spacer/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}

.block-library-spacer__resize-handler-bottom {
@include resize-handler-container();
@include resize-handler__container();

// Offset the handle container's position.
position: absolute;
Expand All @@ -18,5 +18,5 @@
}

.block-library-spacer__resize-handler-bottom::before {
@include resize-handler();
@include resize-handler__visible-handle();
}