Skip to content

Fix/media caption processing #10532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ellatrix merged 1 commit into from
Oct 16, 2018
Merged

Fix/media caption processing #10532

ellatrix merged 1 commit into from
Oct 16, 2018

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Oct 11, 2018 •
edited
Loading

Description

Media processing wasn't updated during #10439. The good thing now is that the format is just HTML, so we can pass the caption directly to RichText without any conversions.

How has this been tested?

Test the image and gallery blocks by inserting images form the media library with captions.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Media Anything that impacts the experience of managing media labels Oct 11, 2018
@ellatrix ellatrix added this to the 4.0 milestone Oct 11, 2018
@ellatrix ellatrix requested review from a team and jorgefilipecosta October 11, 2018 18:55
@ellatrix ellatrix force-pushed the fix/media-caption-processing branch from f60663f to 52aec31 Compare October 11, 2018 19:41
@ellatrix ellatrix added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels Oct 12, 2018
@ellatrix ellatrix mentioned this pull request Oct 16, 2018
Closed
youknowriad
youknowriad approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ellatrix ellatrix merged commit a63d70e into master Oct 16, 2018
@ellatrix ellatrix deleted the fix/media-caption-processing branch October 16, 2018 09:17
This was referenced Oct 16, 2018
Closed
Closed
@youknowriad youknowriad mentioned this pull request Oct 16, 2018
Closed
mcsf pushed a commit that referenced this pull request Nov 1, 2018
@ellatrix @tofumatt
Fix caption processing for media blocks (#10532)
32636eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees

No one assigned

Labels

[Feature] Media Anything that impacts the experience of managing media [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ellatrix @youknowriad