-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Adjust rich-text source mentions in docs #10534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tofumatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! I suggested a tweak but feel free to make it if it makes sense, then merge.
docs/block-api/attributes.md
Outdated
| // " vel urna." | ||
| // ] | ||
| // } | ||
| // { "content": "<p>Quoted text</p><p>And more</p>" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using an example like "<p>Quoted text</p><p>Second line</p>" might make this a bit more immediately obvious.
|
It's tricky to assign proper milestone :D As it is synced with Gutenberg handbook up to 15 minutes after the merge. |
|
@gziolo Not sure I understand... could you elaborate? |
|
Please check https://wordpress.org/gutenberg/handbook/block-api/#attributes-optional - your changes are already there. The flow for documentation is not ideal. That's why we still put milestone according to the plugin release schedule. Next release is 4.1 as 4.0-RC can get only patches before it gets out. Ideally, Gutenberg handbook should show docs for 3.9 release, 4.0-RC as an option and |
|
BTW, @pento @youknowriad - do we have anything planned to fix the issue with the content of Gutenberg handbook as 5.0 goes out? |
|
Wow. Before it's even merged? |
I merged PR, if this is what you ask :) |
Description
After #10439, adjusts the docs to suggest 'html' source instead of 'rich-text'.
How has this been tested?
Screenshots
Types of changes
Checklist: