Skip to content

Conversation

@ellatrix
Copy link
Member

Description

After #10439, adjusts the docs to suggest 'html' source instead of 'rich-text'.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Oct 11, 2018
@ellatrix ellatrix added this to the 4.0 milestone Oct 11, 2018
@ellatrix ellatrix requested a review from a team October 11, 2018 19:38
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I suggested a tweak but feel free to make it if it makes sense, then merge.

// " vel urna."
// ]
// }
// { "content": "<p>Quoted text</p><p>And more</p>" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using an example like "<p>Quoted text</p><p>Second line</p>" might make this a bit more immediately obvious.

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Oct 12, 2018
@gziolo gziolo modified the milestones: 4.0, 4.1 Oct 12, 2018
@gziolo gziolo merged commit 8d80814 into master Oct 12, 2018
@gziolo gziolo deleted the fix/rich-text-source-docs branch October 12, 2018 07:41
@gziolo
Copy link
Member

gziolo commented Oct 12, 2018

It's tricky to assign proper milestone :D As it is synced with Gutenberg handbook up to 15 minutes after the merge.

@ellatrix
Copy link
Member Author

@gziolo Not sure I understand... could you elaborate?

@gziolo
Copy link
Member

gziolo commented Oct 12, 2018

Please check https://wordpress.org/gutenberg/handbook/block-api/#attributes-optional - your changes are already there. The flow for documentation is not ideal. That's why we still put milestone according to the plugin release schedule. Next release is 4.1 as 4.0-RC can get only patches before it gets out. Ideally, Gutenberg handbook should show docs for 3.9 release, 4.0-RC as an option and development (your changes) as yet another option.

@gziolo
Copy link
Member

gziolo commented Oct 12, 2018

BTW, @pento @youknowriad - do we have anything planned to fix the issue with the content of Gutenberg handbook as 5.0 goes out?

@ellatrix
Copy link
Member Author

Wow. Before it's even merged?

@gziolo
Copy link
Member

gziolo commented Oct 12, 2018

Before it's even merged?

I merged PR, if this is what you ask :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants