Fix: Always use the latest version of NVM #10586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the local dev enviornment pins to a 10 month old version of NVM, which means that when we say we are "updating NVM", it can easily be downgrading NVM. This adds a one line to get the latest version and use that.
tofumatt
approved these changes
Oct 14, 2018
Member
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
I didn't write or review this code so I'm not sure why we are using that version of NVM. A consistent environment is nice but in the case of NVM I'm fine with just using the latest version.
This gets 👍 from me, but @pento wrote that line and could perhaps explain the reasoning behind it? 🤷♂️
pento
approved these changes
Oct 16, 2018
Member
pento
left a comment
pento
left a comment
There was a problem hiding this comment.
I originally wrote it as a "here's a version that works" thing, but realistically, I don't expect our basic usage of NVM to cause back compat problems.
Contributor
|
@pento In windows environment, |
Member
|
@shivapoudel: This script will likely become obsolete when #17004 is merged, so I don't think it'll be changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the local dev enviornment pins to a 10 month old version of NVM, which means that when we say we are "updating NVM", it can easily be downgrading NVM. This adds a one line to get the latest version and use that.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: