i18n: Mark custom font sizes labels as translatable #10615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
added
the
Internationalization (i18n)
Soean
approved these changes
Oct 15, 2018
Member
|
Thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #9802 Font Size Picker was updated, but two labels that are shown for custom sizes were not i18n.
For the first label, I used existing string from
EDITOR_SETTINGS_DEFAULTS.fontSizeswhile for the second I added context since it wasn't used before. Context is proposed for both strings in #8710, which introduces context for much more strings. If #8710 is accepted and merged before this PR, this PR will become obsolete