Handle metabox warning exceptions #10999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor of the `ReflectionMethod` and `ReflectionFunction` classes can throw a `ReflectionException` if they are passed an ivlaid or broken `$callable`. We should catch these exceptions and make sure they don't propagate and take the server down, just to stay on the safe side. See http://php.net/manual/en/reflectionmethod.construct.php & http://php.net/manual/en/reflectionfunction.construct.php
Soean
added
the
[Feature] Meta Boxes
jorgefilipecosta
approved these changes
Nov 1, 2018
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
From the code point of view, this change looks good 👍 cc: @pento as this will need to be backported to the WordPress beta.
Member
|
👍🏻 @schlessera: Would you mind creating a core ticket and patch for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor of the
ReflectionMethodandReflectionFunctionclasses can throw aReflectionExceptionif they are passed an invalid or broken$callable.We should catch these exceptions and make sure they don't propagate and take the server down, just to stay on the safe side.
See http://php.net/manual/en/reflectionmethod.construct.php & http://php.net/manual/en/reflectionfunction.construct.php