-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Make help text more in line with other help texts #11068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello -- thanks for the copy review ping! Can I see the original and proposed versions of the text? |
|
If you click on files changed, you see the versions in a diff. Here they are: The context is the preview in the embed block. |
|
Thanks for the GitHub education! I'd go with:
|
|
Two notes:
|
|
@kristastevens, I agree with @dimadin that it needs to be more specific given that it's directly related to embeds. |
|
How about:
|
|
@gziolo, I think @notnownikki makes a great suggestion:
|
|
@dimadin, sounds like we have a winner with that last iteration ("Sorry, we cannot preview this embedded content in the editor."). What's the status of this PR? |
gziolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the copy with the latest suggestion 👍
tofumatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it 😄
Restarted the buggy tests and they passed.
* Make help text more in line with other help texts. * Remove submodule. * Update embed-preview.js
* Make help text more in line with other help texts. * Remove submodule. * Update embed-preview.js
This PR changes one help text string: it moves "sorry" to the start of the string, and it removes exclamation mark from the end.