Skip to content

Conversation

@dimadin
Copy link
Contributor

@dimadin dimadin commented Oct 25, 2018

This PR changes one help text string: it moves "sorry" to the start of the string, and it removes exclamation mark from the end.

@Soean Soean added [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Oct 25, 2018
@kristastevens
Copy link

Hello -- thanks for the copy review ping! Can I see the original and proposed versions of the text?

@Soean
Copy link
Member

Soean commented Oct 25, 2018

If you click on files changed, you see the versions in a diff.

Here they are:
Old: Previews for this are unavailable in the editor, sorry!
New: Sorry, previews for this are unavailable in the editor.

The context is the preview in the embed block.

@kristastevens
Copy link

Thanks for the GitHub education!

I'd go with:

Sorry, a preview is unavailable in the editor.

@dimadin
Copy link
Contributor Author

dimadin commented Oct 25, 2018

Two notes:

  • Other similar strings in both WordPress core and Gutenberg start with "Sorry," and end in full stop. This is why I reported this string.
  • It might be valuable to know context in which this string shows up: it's in Embed block when user is trying to embed content from a site that is blacklisted from having embed previews (correct me if I'm wrong).

@gziolo
Copy link
Member

gziolo commented Nov 22, 2018

@kristastevens, I agree with @dimadin that it needs to be more specific given that it's directly related to embeds.

@gziolo gziolo requested a review from notnownikki November 22, 2018 09:36
@notnownikki
Copy link
Member

How about:

Sorry, we cannot preview this embedded content in the editor.

@gziolo gziolo added this to the 4.6 milestone Nov 22, 2018
@kristastevens
Copy link

@gziolo, I think @notnownikki makes a great suggestion:

Sorry, we cannot preview this embedded content in the editor.

@mtias mtias modified the milestones: 4.6, 4.7 Nov 22, 2018
@mtias mtias added the [Block] Embed Affects the Embed Block label Dec 6, 2018
@mcsf
Copy link
Contributor

mcsf commented Dec 9, 2018

@dimadin, sounds like we have a winner with that last iteration ("Sorry, we cannot preview this embedded content in the editor."). What's the status of this PR?

@mcsf mcsf modified the milestones: 4.7, 4.8 Dec 9, 2018
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the copy with the latest suggestion 👍

Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it 😄

Restarted the buggy tests and they passed.

@tofumatt tofumatt merged commit d0879a4 into WordPress:master Dec 20, 2018
youknowriad pushed a commit that referenced this pull request Jan 9, 2019
* Make help text more in line with other help texts.

* Remove submodule.

* Update embed-preview.js
youknowriad pushed a commit that referenced this pull request Jan 9, 2019
* Make help text more in line with other help texts.

* Remove submodule.

* Update embed-preview.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Embed Affects the Embed Block Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants