Skip to content

Conversation

@ellatrix
Copy link
Member

Fixes #1002. Props @westonruter.

Testing: make sure no embedded content can be tabbed into or clicked.

@ellatrix ellatrix self-assigned this Jun 10, 2017
@ellatrix ellatrix requested review from mtias and notnownikki June 10, 2017 13:57
@notnownikki
Copy link
Member

👍

Solves the problem of accidentally playing videos when setting captions on youtube embeds, too. Nice!

@ellatrix
Copy link
Member Author

Hm, the tabIndex doesn't work. Turns out you have to add that to all focusable descendants... I'm not sure how to proceed as there seems to be no way to prevent tabbing inside the embed.

@ellatrix
Copy link
Member Author

Closing for the above reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants