Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 31, 2018

Add WordPress.org Username.
Follow up to #1350

Add WordPress.org Username.
Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked a few. Thanks for working on this, @pratikthink!

@desrosj desrosj added the [Type] Developer Documentation Documentation for developers label Oct 31, 2018
Soean and others added 3 commits November 1, 2018 03:44
Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small changes. Let's not add spaces to the lines I marked. We are no longer changing those lines, so let's leave them the same.

@ghost
Copy link
Author

ghost commented Nov 1, 2018

😊

Co-Authored-By: pratikthink <[email protected]>
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Nov 1, 2018

I am the first-timer and it was a nice experience for me.

Co-Authored-By: pratikthink <[email protected]>
@Soean Soean requested a review from desrosj November 2, 2018 09:24
@desrosj desrosj merged commit 60e0b50 into WordPress:master Nov 3, 2018
@desrosj
Copy link
Member

desrosj commented Nov 3, 2018

Thank you, @pratikthink! Hope to see you around some more.

@ghost ghost deleted the patch-1 branch November 3, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants