Skip to content

Conversation

@aduth
Copy link
Member

@aduth aduth commented Nov 1, 2018

This pull request seeks to upgrade the hpq dependency from 1.2.0 to 1.3.0. The 1.3.0 release is performance-oriented, improving parse by approximately a factor of 4x (Try Benchmark). This was discovered in a performance profile of Gutenberg to be a top candidate for boot-time delays, moreso for larger posts, as each individual block will have previously been rendered into a separate created document.

View Changelog
Notable relevant hpq commit
Try Benchmark

Testing instructions:

This is a dependency minor release update, and is not anticipated to have any incompatible changes.

@aduth aduth added [Type] Performance Related to performance efforts [Package] Blocks /packages/blocks labels Nov 1, 2018
@aduth aduth force-pushed the upgrade/hpq-1-3-0 branch from 101acd1 to 2e034df Compare November 1, 2018 13:46
@ellatrix
Copy link
Member

ellatrix commented Nov 1, 2018

Sounds great, there's just test failures.

@ocean90
Copy link
Member

ocean90 commented Nov 1, 2018

627befd fixes package-lock.json so hpq gets correctly installed.

@aduth
Copy link
Member Author

aduth commented Nov 1, 2018

Thanks @ocean90, I was having a heck of a time getting the package-lock.json file to update correctly.

Only needs an approving review now.

@aduth aduth merged commit daa2ea9 into master Nov 2, 2018
@aduth aduth deleted the upgrade/hpq-1-3-0 branch November 2, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Blocks /packages/blocks [Type] Performance Related to performance efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants