Skip to content

Conversation

@Luciaisacomputer
Copy link
Contributor

Description

In #11345 it is noted that the add block button does not appear visually to users when tabbing through blocks. The fix for me seemed to be adding a :focus state for the toggle button itself which sets the opacity of the bottom to 1, making it appear.

It's possible that some class names changed which cause this as I did see a .is-visible class reference. There is a parent Div node that does receive the class on focus. Hopefully someone knows the original implementation details and can speak to that.

How has this been tested?

I opened edit post screen in Chrome, Safari, Firefox, IE11, and Edge. Then I tabbed backwards through several paragraph blocks. Each time the button appeared for me.

Screenshots

screen shot 2018-11-01 at 4 33 58 pm

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@mtias
Copy link
Member

mtias commented Nov 12, 2018

Thanks for the contribution. This already seems addressed by #11685

@mtias mtias closed this Nov 12, 2018
@Luciaisacomputer Luciaisacomputer deleted the fix/add-block-button-hidden branch November 12, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants