Skip to content

Conversation

@ruhel241
Copy link

@ruhel241 ruhel241 commented Nov 2, 2018

On version 4.1.1 we can't get the FontSizePicker from wp/components. We need to import from editor.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Nov 2, 2018
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ruhel241, thank you a lot for you contribution.
It is still possible to use FontSizePicker from '@wordpress/components'. The components version should be used when the block just wants to allow the selection of specific set of FontSizes e.g: Small and Big, independtly of what is available gloabally, so the fontSizes array should be passed. The editor version uses the fontSizes provided by the theme or the default ones.
I noticed the documentation of FontSizePicker in '@wordpress/components' was outdated making it look like it does not work so I created a PR that updates the documentation: #11404.

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Nov 12, 2018

As #11404 was already merged I'm closing this PR!
Thank you for making us notice a documentation problem and for trying to handle the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants