Fix disabled undo button timeout #11399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
approved these changes
Nov 2, 2018
Member
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
Looks good to me, just little suggestions. Awesome work, the times of restarting timed-out tests is over! 🎉
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets rid of the timeouts we've been seeing in the undo e2e tests. The cause is the
RECEIVE_BLOCKSaction sometimes dispatching between twoUPDATE_BLOCK_ATTRIBUTESactions. TheRECEIVE_BLOCKSis not fully ignored: it does not create a new history record, but it does set thelastActionattribute. This causesshouldOverwriteStateto return false where it shouldn't, because it compares the current and previous action.How has this been tested?
Screenshots
Types of changes
Checklist: