Add image and video transformations in Media & Text block #11420
Conversation
jorgefilipecosta
force-pushed
the
add/image-and-video-transformations-media-text-block
branch
from
0dd4e7b to
303c1dc
Compare
jorgefilipecosta
force-pushed
the
add/image-and-video-transformations-media-text-block
branch
from
303c1dc to
025b551
Compare
| alt: mediaAlt, | ||
| id: mediaId, | ||
| url: mediaUrl, | ||
| } ); |
There was a problem hiding this comment.
What about the text of the inner blocks? Should we just return them in addition to this block to keep them after the image block?
There was a problem hiding this comment.
I thought about it, but unfortunately, our transforms API does not pass the child blocks. I think it would be a nice improvement in the API and I can work on it. At the time I did not add this because I was not sure if it collided with the freeze. I think we may manage to get something working without breaking any back compatibility I can give it a try.
There was a problem hiding this comment.
I think this is fine. This change, to me, is mostly about the ergonomics of quickly switching between "image-type" blocks. In the future, a more comprehensive transform will be a welcome addition; until then, the Undo button is what allows the user to try a conversion and roll back at any time.
mcsf
added
the
[Feature] Block Transforms
| alt: mediaAlt, | ||
| id: mediaId, | ||
| url: mediaUrl, | ||
| } ); |
There was a problem hiding this comment.
I think this is fine. This change, to me, is mostly about the ergonomics of quickly switching between "image-type" blocks. In the future, a more comprehensive transform will be a welcome addition; until then, the Undo button is what allows the user to try a conversion and roll back at any time.
jorgefilipecosta
deleted the
add/image-and-video-transformations-media-text-block
branch
|
Thank you for the reviews! |
Description
This pr adds "Media & Text" <-> Video, Image transforms.
How has this been tested?
Add a video block. Transform it to Media & Text and verify it worked as expected.
Add an image block. Transform it to Media & Text and verify it worked as expected.
Transform both blocks back to video and image.
Add a media text block select an image and transform it to image block.
Add a media text block select a video and transform it to video block.
Transform the image and videos back to media & text.