Skip to content

Update the block styles registration to avoid timing issues #11532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 5 commits into from
Nov 9, 2018
Merged

Update the block styles registration to avoid timing issues #11532

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e4cee8
Update the block styles registration to avoid timing issues
youknowriad Nov 6, 2018
29503ed
Update changelogs
youknowriad Nov 6, 2018
eda408a
Update data docs
youknowriad Nov 6, 2018
c89b880
Fix e2e tests
youknowriad Nov 6, 2018
484fcfb
Omit styles from the block settings object
youknowriad Nov 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix e2e tests
  • Loading branch information
@youknowriad
youknowriad committed Nov 9, 2018
commit c89b8800f0464e1439e134fc00083670aa8bb4d5
3 changes: 2 additions & 1 deletion packages/editor/src/components/block-switcher/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ export default compose(
const { getBlockStyles } = select( 'core/blocks' );
const rootClientId = getBlockRootClientId( first( castArray( clientIds ) ) );
const blocks = getBlocksByClientId( clientIds );
const styles = blocks && blocks.length === 1 && getBlockStyles( blocks[ 0 ].name );
const firstBlock = blocks && blocks.length === 1 ? blocks[ 0 ] : null;
const styles = firstBlock && getBlockStyles( firstBlock.name );
return {
blocks,
inserterItems: getInserterItems( rootClientId ),
Expand Down