Allow a block to disable being converted into a reusable block; Fix: Column block #11550
Conversation
jorgefilipecosta
added
[Type] Bug
docs/block-api.md
Outdated
There was a problem hiding this comment.
Small nit but these should all be one line, no line breaks :)
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
A few small non-code details to fix up, but code looks / works great 👍
There was a problem hiding this comment.
This comment now only really covers part of what's being done with the every condition. We might want to enhance it slightly, or even move it to cover the specific parts of the predicate for which it is relevant (!! block && block.isValid, with complementing comment for the hasBlockSupport check).
There was a problem hiding this comment.
I like that we formalize this on the blocks API rather than ad hoc exemptions 👍
docs/block-api.md
Outdated
There was a problem hiding this comment.
I think this is missing a sentence stop between "block" and "if"
jorgefilipecosta
force-pushed
the
add/flag-that-allows-disable-of-the-converstion-to-reusable-blocks
branch
from
9e127e0 to
e5325fc
Compare
jorgefilipecosta
deleted the
add/flag-that-allows-disable-of-the-converstion-to-reusable-blocks
branch
…rnmobile/fix-merge-content-not-refreshed-UI * 'master' of https://github.com/WordPress/gutenberg: Fix the isBeingScheduled Selector. (#11572) Slot/Fill pattern with Toolbar #199 (#11115) Add mechanism to avoid forced child selection on blocks with templates. (#10696) Allow a block to disable being converted into a reusable block; Fix: Column block (#11550)
Fixes: #10679
This PR adds a flag that allows a block to opt-out being converted into a reusable block as discussed in #10679.
This new logic is used to disable the conversion of column block into a reusable block and to simplify existing logic that disables classic and missing block conversion to reusable blocks.
These simplifications add a behavior change.
Before it was not possible to convert classic or missing block into a reusable block, but if another block was selected with it (even an empty paragraph) it was possible to convert that blocks into reusable blocks, now that's not the case.
If a block that is part of the selection cannot be converted into a reusable block, the option to convert the selected blocks into a reusable block will not be shown.
I think that is the desired behavior.
How has this been tested?
Verify it is not possible to convert to reusable blocks, the "Column" block, the classic block or an invalid block.
Verify it is still possible to convert to reusable blocks the "Columns" block.
Test complex scenarios e.g. multiple selections of Columns and a paragraph, and verify the conversion is possible.