Restore native backspace behaviour #11627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There's one failing e2e test: if you select a whole paragraph, it seems TinyMCE is doing some weird stuff. |
ellatrix
commented
Nov 8, 2018
| onKeyDown( event ) { | ||
| const { keyCode } = event; | ||
| const { startContainer, startOffset, endContainer, endOffset } = getSelection().getRangeAt( 0 ); | ||
| const isCollapsed = startContainer === endContainer && startOffset === endOffset; |
Member
Author
There was a problem hiding this comment.
getSelection().isCollapsed is not accurate, should prob be commented.
ellatrix
commented
Nov 8, 2018
| const start = getSelectionStart( value ); | ||
| const end = getSelectionEnd( value ); | ||
|
|
||
| // Always handle uncollapsed selections ourselves. |
Member
Author
There was a problem hiding this comment.
Could use more comment sorry.
gziolo
added
[Type] Bug
Member
Author
|
Thanks! Could you also add an e2e test for word wise deletion alt+backspace? Thanks so much! |
Member
|
Sure :) |
youknowriad
reviewed
Nov 9, 2018
| await page.keyboard.type( 'delta' ); | ||
| const blockText = await page.evaluate( () => document.activeElement.textContent ); | ||
| expect( blockText ).toBe( 'alpha beta gamma delta' ); | ||
| } ); |
Member
|
I'm going through the linked issues and adding e2e tests where I can. I want to get an e2e test for #6021 next. So far, all is looking good! |
Contributor
Nice, feel free to open follow-up PRs with more e2e test 🎉 |
This was referenced Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores a part of #11287. It should not restore any bugginess! :)
We need to make sure none of the issues that #10799 fixed are reintroduced.
Still needs e2e test and investigate failing e2e tests.
How has this been tested?
Screenshots
Types of changes
Checklist: