Skip to content

Conversation

@pinarol
Copy link
Contributor

@pinarol pinarol commented Nov 8, 2018

Description

This update is for handling situations where user just presses Cancel on the media picker.
We don't want the image block to update in that case.

How has this been tested?

Test steps can be found on parent PR

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

This is for handling situations where user just presses Cancel on the media picker.
We don't want the image block to update in that case.
@pinarol pinarol added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 8, 2018
@pinarol pinarol requested review from etoledom and hypest November 8, 2018 16:45
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinarol pinarol merged commit 5531bd1 into master Nov 9, 2018
@youknowriad youknowriad added this to the 4.3 milestone Nov 9, 2018
@pinarol pinarol deleted the rnmobile/fix-imageblock-callback branch November 9, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants