Improve documentation in CONTRIBUTING.md file #11657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve documentation in CONTRIBUTING.md file. Title-cased the headings and fixed grammatical/typo issues and errors.
ocean90
changed the title
youknowriad
added
the
Needs Copy Review
|
Is there anything in particular you need reviewed? |
Contributor
|
I just wanted a quick check for the proposed changes 🤷♂️ |
|
In line 26, I'd move "also" before "need." In line 51, I'd keep the original "you'll." In line 117, lowercase a. Otherwise, looks good! |
Member
|
@MaedahBatool can you rebase this PR and address feedback from @michelleweber? Thanks :) |
gziolo
approved these changes
Dec 20, 2018
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I applied changes myself. @MaedahBatool thanks for your contribution and @michelleweber for copy review. This looks like a nice improvement.
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Improve: Docs in CONTRIBUTING.md file Improve documentation in CONTRIBUTING.md file. Title-cased the headings and fixed grammatical/typo issues and errors. * Applied comments from feedback #11657 (comment)
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Improve: Docs in CONTRIBUTING.md file Improve documentation in CONTRIBUTING.md file. Title-cased the headings and fixed grammatical/typo issues and errors. * Applied comments from feedback #11657 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve documentation in CONTRIBUTING.md file. Title-cased the headings and fixed grammatical/typo issues and errors.
How has this been tested?
Screenshots
Types of changes
Checklist: