Skip to content

Conversation

@pinarol
Copy link
Contributor

@pinarol pinarol commented Nov 9, 2018

Description

This PR includes changes for adding toolbar to image block and also adding edit button in it.

How has this been tested?

  • Refer to parent PR to find out how to setup the testing environment.

Test 1:

  • Open a blog post
  • Add image block, tap Media Library, select an image
  • Add another image block but don't set an image for it
  • Tap on the image block with an image set, verify that toolbar is visible
  • Tap on the image block with no image is set, verify that toolbar isn't visible

Test 2:

  • Open a blog post
  • Add image block, tap Media Library, select an image
  • See that toolbar appears with an edit button in it(pencil icon)
  • Tap edit button in the toolbar
  • Verify that image picker is opened, select an image
  • Verify that image is changed in the image block

Test 3:

  • Open a blog post
  • Add image block, tap Media Library, select an image
  • See that toolbar appears with an edit button in it(pencil icon)
  • Tap edit button in the toolbar
  • Verify that image picker is opened, tap "Cancel"
  • Verify that image is NOT changed in the image block

Screenshots

screen shot 2018-11-09 at 13 49 07

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@pinarol pinarol added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 9, 2018
@pinarol pinarol requested review from etoledom and hypest and removed request for hypest November 9, 2018 11:13
@pinarol
Copy link
Contributor Author

pinarol commented Nov 12, 2018

Rafactored due to edit.js, ready to review again @etoledom @hypest

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinarol pinarol merged commit 42d1fe5 into master Nov 12, 2018
@pinarol pinarol deleted the rnmobile/image-block-toolbar branch November 13, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants