Editor: Resolve macOS Firefox / Safari sibling inserter behavior #11684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
mcsf
approved these changes
Nov 9, 2018
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
Thanks for the proper documentation and fix. WFM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where attempting to use the sibling inserter in Firefox or Safari will result in unintended block selection (see example).
The reason for this can be attributed to browser-and-OS-specific handling of
clickandfocusevents, specifically affecting Firefox and Safari on macOS.See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#Clicking_and_focus
The changes here reason this issue by allowing the
divwrapper to be focusable (not tabbable), thus receiving thefocusevent on itself.Testing instructions:
Verify that the sibling inserter behaves as expected in your preferred browser, and in Firefox and Safari for macOS.