Skip to content

Update displayed permalink when slug is cleared #11783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 9 commits into from
Nov 20, 2018
Merged

Update displayed permalink when slug is cleared #11783

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
115e76b
Update displayed permalink when slug is cleared
earnjam Nov 12, 2018
23a2af6
Trim spaces and hyphens from beginning and end
earnjam Nov 19, 2018
5e6e56b
Use withSelect instead of forwarding props
earnjam Nov 19, 2018
673a2fa
Slug instead of postSlug
earnjam Nov 19, 2018
5584199
Add unit test for cleanForSlug
earnjam Nov 19, 2018
59aeb5a
Fall back to post ID when title and slug are blank
earnjam Nov 19, 2018
60f3d66
Export cleanForSlug
earnjam Nov 20, 2018
685788f
Add support for clearing & processing slug in sidebar permalink panel
earnjam Nov 20, 2018
1265a32
Fall back to post ID in sidebar when slug and title are empty
earnjam Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit test for cleanForSlug
  • Loading branch information
@earnjam
earnjam committed Nov 19, 2018
commit 5584199383bb84224de925677b623662990618f5
10 changes: 10 additions & 0 deletions packages/editor/src/utils/test/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* Internal dependencies
*/
import { cleanForSlug } from '../url';

describe( 'cleanForSlug()', () => {
it( 'Should return string prepared for use as url slug', () => {
expect( cleanForSlug( ' /Déjà_vu. ' ) ).toBe( 'deja-vu' );
} );
} );