Fix block selection when removing blocks #11898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Nov 15, 2018
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
This is definitely the corrected behavior for the current implementation.
The current implementation doesn't make much sense anymore though. I don't think it's possible to delete a block without it also being the selected block? Probably more relevant when we had the trash can adjacent the hovered block. In any case, this would at least "just work" if something like that were introduced, or a plugin adds another option to delete a block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #11811
This fixes a small typo/error where we were comparing a block Id to a block Object. I don't think it has a lot of impacts on the behavior though.